Sign upLogin

angular/angular.js

View on GitHub
Star
benchmarks/ng-class-bp/app.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function DataController has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

app.controller('DataController', function DataController($scope) {

  this.init = function() {
    this.numberOfTodos = 1000;
    this.implementation = 'tableOptimized';
Severity: Major
Found in benchmarks/ng-class-bp/app.js - About 3 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      benchmarkSteps.push({
    name: 'create',
    fn: function() {
      // initialize data for first time that will construct the DOM
      this.setTodosValuesWithSeed(0);
    Severity: Major
    Found in benchmarks/ng-class-bp/app.js and 2 other locations - About 1 hr to fix
    benchmarks/ng-class-bp/app.js on lines 73..80
    benchmarks/ng-class-bp/app.js on lines 91..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      benchmarkSteps.push({
    name: 'class',
    fn: function() {
      // add all classes as the initial state
      this.setTodosValuesWithSeed(0);
    Severity: Major
    Found in benchmarks/ng-class-bp/app.js and 2 other locations - About 1 hr to fix
    benchmarks/ng-class-bp/app.js on lines 57..64
    benchmarks/ng-class-bp/app.js on lines 73..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      benchmarkSteps.push({
    name: 'update',
    fn: function() {
      // move everything but completed
      this.setTodosValuesWithSeed(3);
    Severity: Major
    Found in benchmarks/ng-class-bp/app.js and 2 other locations - About 1 hr to fix
    benchmarks/ng-class-bp/app.js on lines 57..64
    benchmarks/ng-class-bp/app.js on lines 91..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status